technicie/MarietjeDjango
1
0
Fork 0
mirror of https://gitlab.science.ru.nl/technicie/MarietjeDjango.git synced 2025-12-09 16:32:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(queues): now really fix the request notifications

Browse Source 
Instead of checking for success, now the correct HTTP response code is
sent by the request API. My previous fix broke the other responses, oops.

Closes #82

Relates #44

The refresh as introduced in my fix for #82 (!89) is reverted, as this
was already done on successful requests.
This commit is contained in:
Kees van Kempen
2024-03-05 10:45:16 +01:00
parent 8218803ca8
commit 669e1e3b18
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
marietje/queues/api/v1/views.py
View File

@ -163,7 +163,7 @@ class QueueRequestAPIView(CreateAPIView):
try:
playlist_song = queue.request(song, request.user)
except RequestException as e:
return Response(data={"success": False, "errorMessage": str(e)})
return Response(status=403, data={"success": False, "errorMessage": str(e)})
request_counter.labels(queue=queue.name).inc()
return Response(status=200, data=self.serializer_class(playlist_song).data)

4
marietje/queues/templates/queues/queue.html
View File

@ -594,8 +594,7 @@
"Content-Type": 'application/json',
},
}).then(response => {
// TODO: Communicate failure through HTTP error codes (403) instead of checking response.success.
if (response.status === 200 && response.success) {
if (response.status === 200) {
return response.json();
} else {
throw response;
@ -612,7 +611,6 @@
tata.error('', "An unknown exception occurred.")
}
});
queue_vue.refresh();
},
report_song(song_id) {